summaryrefslogtreecommitdiff
path: root/netwerk
diff options
context:
space:
mode:
authorValentin Gosu <valentin.gosu@gmail.com>2018-02-11 03:51:09 +0100
committerwolfbeast <mcwerewolf@gmail.com>2018-03-14 11:03:59 +0100
commit879619491f79870170abb0d398ab6a5c506984b0 (patch)
tree657d874565dbcc889f858a88d2d95e88a6dc9499 /netwerk
parent8f7686bd7d4034c122ce050de9070e472952cf61 (diff)
downloaduxp-879619491f79870170abb0d398ab6a5c506984b0.tar.gz
Bug 1334465 - Set mIPCClosed to true before calling SendDeleteSelf in order to avoid race. r=bagder, a=ritu
In the previous code, a race condition could cause us to call SendSetPriority() after calling SendDeleteSelf. For example: T1: SendDeleteSelf() T2: if (!mIPCClosed) SendSetPriority() T1: mIPCClosed = true MozReview-Commit-ID: 3XOwCaphb2o --HG-- extra : rebase_source : d6e6886402d1e0b0afed23c25a9fb18d8ca29ad6 extra : intermediate-source : cfc9afe916091e6449f7d748991e2a19187dc817 extra : source : 4ebdab0e332892378558817e30d0138c95199ce5
Diffstat (limited to 'netwerk')
-rw-r--r--netwerk/protocol/http/HttpChannelParent.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/netwerk/protocol/http/HttpChannelParent.cpp b/netwerk/protocol/http/HttpChannelParent.cpp
index fe076a237e..5f0859f288 100644
--- a/netwerk/protocol/http/HttpChannelParent.cpp
+++ b/netwerk/protocol/http/HttpChannelParent.cpp
@@ -1772,8 +1772,8 @@ HttpChannelParent::UpdateAndSerializeSecurityInfo(nsACString& aSerializedSecurit
bool
HttpChannelParent::DoSendDeleteSelf()
{
- bool rv = SendDeleteSelf();
mIPCClosed = true;
+ bool rv = SendDeleteSelf();
return rv;
}