Issue #2343 - replace MOZ_FALLTHROUGH with [[fallthrough]]

Basically a S&R. Removed the macro and adjusts IDL codegen accordingly.

14 files changed, 23 insertions, 23 deletions

diff --git a/mailnews/base/search/src/nsMsgFilterService.cpp b/mailnews/base/search/src/nsMsgFilterService.cpp
index c8f52de5aa..9fd0c23e55 100644
--- a/mailnews/base/search/src/nsMsgFilterService.cpp
+++ b/mailnews/base/search/src/nsMsgFilterService.cpp
@@ -609,7 +609,7 @@ nsresult nsMsgFilterAfterTheFact::ApplyFilter()
         //   would not have run if move succeeded.
         m_nextAction = numActions;
         // Fall through to the copy case.
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case nsMsgFilterAction::CopyToFolder:
       {
         nsCString uri;
diff --git a/mailnews/base/search/src/nsMsgSearchAdapter.cpp b/mailnews/base/search/src/nsMsgSearchAdapter.cpp
index a6f8778305..52a76a9dd1 100644
--- a/mailnews/base/search/src/nsMsgSearchAdapter.cpp
+++ b/mailnews/base/search/src/nsMsgSearchAdapter.cpp
@@ -334,7 +334,7 @@ nsresult nsMsgSearchAdapter::EncodeImapTerm (nsIMsgSearchTerm *term, bool really
   case nsMsgSearchAttrib::ToOrCC:
     orHeaderMnemonic = m_kImapCC;
     // fall through to case nsMsgSearchAttrib::To:
-    MOZ_FALLTHROUGH;
+    [[fallthrough]];
   case nsMsgSearchAttrib::To:
     whichMnemonic = m_kImapTo;
     break;
diff --git a/mailnews/base/src/nsMsgDBView.cpp b/mailnews/base/src/nsMsgDBView.cpp
index 5b82390c00..281d715291 100644
--- a/mailnews/base/src/nsMsgDBView.cpp
+++ b/mailnews/base/src/nsMsgDBView.cpp
@@ -6450,7 +6450,7 @@ NS_IMETHODIMP nsMsgDBView::NoteChange(nsMsgViewIndex firstLineChanged,
       // RowCountChanged() will call our GetRowCount()
       mTree->RowCountChanged(firstLineChanged, numChanged);
       mRemovingRow = false;
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case nsMsgViewNotificationCode::all:
       ClearHdrCache();
       break;
@@ -6730,7 +6730,7 @@ nsresult nsMsgDBView::NavigateFromPos(nsMsgNavigationTypeValue motion, nsMsgView
             break;
         case nsMsgNavigationType::firstUnreadMessage:
             startIndex = nsMsgViewIndex_None;        // note fall thru - is this motion ever used?
-            MOZ_FALLTHROUGH;
+            [[fallthrough]];
         case nsMsgNavigationType::nextUnreadMessage:
             for (curIndex = (startIndex == nsMsgViewIndex_None) ? 0 : startIndex; curIndex <= lastIndex && lastIndex != nsMsgViewIndex_None; curIndex++) {
                 uint32_t flags = m_flags[curIndex];
diff --git a/mailnews/base/src/nsMsgGroupView.cpp b/mailnews/base/src/nsMsgGroupView.cpp
index f3d9a27041..1f20a0378b 100644
--- a/mailnews/base/src/nsMsgGroupView.cpp
+++ b/mailnews/base/src/nsMsgGroupView.cpp
@@ -227,7 +227,7 @@ nsresult nsMsgGroupView::HashHdr(nsIMsgDBHdr *msgHdr, nsString& aHashKey)
       break;
     case nsMsgViewSortType::byReceived:
       rcvDate = true;
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case nsMsgViewSortType::byDate:
     {
       uint32_t ageBucket;
@@ -799,7 +799,7 @@ NS_IMETHODIMP nsMsgGroupView::CellTextForColumn(int32_t aRow,
       {
         case nsMsgViewSortType::byReceived:
           rcvDate = true;
-          MOZ_FALLTHROUGH;
+          [[fallthrough]];
         case nsMsgViewSortType::byDate:
         {
           uint32_t ageBucket = 0;
diff --git a/mailnews/compose/src/nsMsgSend.cpp b/mailnews/compose/src/nsMsgSend.cpp
index 919d9bfc54..17a54286ea 100644
--- a/mailnews/compose/src/nsMsgSend.cpp
+++ b/mailnews/compose/src/nsMsgSend.cpp
@@ -174,7 +174,7 @@ static nsresult StripOutGroupNames(char * addresses)
           group = false;
           //end of the group, act like a recipient separator now...
         /* NO BREAK */
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case ',':
         if (!quoted)
         {
diff --git a/mailnews/compose/src/nsSmtpProtocol.cpp b/mailnews/compose/src/nsSmtpProtocol.cpp
index 89607224ed..a2c86a6eba 100644
--- a/mailnews/compose/src/nsSmtpProtocol.cpp
+++ b/mailnews/compose/src/nsSmtpProtocol.cpp
@@ -920,7 +920,7 @@ void nsSmtpProtocol::InitPrefAuthMethods(int32_t authMethodPrefValue)
       MOZ_LOG(SMTPLogModule, mozilla::LogLevel::Error,
           ("SMTP: bad pref authMethod = %d\n", authMethodPrefValue));
       // fall to any
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case nsMsgAuthMethod::anything:
       m_prefAuthMethods =
           SMTP_AUTH_LOGIN_ENABLED | SMTP_AUTH_PLAIN_ENABLED |
diff --git a/mailnews/db/msgdb/src/nsMsgHdr.cpp b/mailnews/db/msgdb/src/nsMsgHdr.cpp
index 7c5cf57097..2ff1cce192 100644
--- a/mailnews/db/msgdb/src/nsMsgHdr.cpp
+++ b/mailnews/db/msgdb/src/nsMsgHdr.cpp
@@ -769,7 +769,7 @@ const char *nsMsgHdr::GetNextReference(const char *startNextRef,
         // intentional fallthrough so whitespaceEndedAt will definitely have
         //  a non-NULL value, just in case the message-id is not valid (no '>')
         //  and the old-school support is desired.
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       default:
         if (!whitespaceEndedAt)
             whitespaceEndedAt = ptr;
diff --git a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
index f879c7aa34..b3e732a443 100644
--- a/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
+++ b/mailnews/extensions/bayesian-spam-filter/src/nsBayesianFilter.cpp
@@ -547,7 +547,7 @@ void Tokenizer::tokenizeHeaders(nsIUTF8StringEnumerator * aHeaderNames, nsIUTF8S
         if (Substring(headerName, 0, 9).Equals("x-mozilla"))
           break;
         // fall through
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
     case 'u':
         addTokenForHeader(headerName.get(), headerValue);
         break;
diff --git a/mailnews/imap/src/nsImapMailFolder.cpp b/mailnews/imap/src/nsImapMailFolder.cpp
index 1d08472bb9..5b38433923 100644
--- a/mailnews/imap/src/nsImapMailFolder.cpp
+++ b/mailnews/imap/src/nsImapMailFolder.cpp
@@ -3508,7 +3508,7 @@ NS_IMETHODIMP nsImapMailFolder::ApplyFilterHit(nsIMsgFilter *filter, nsIMsgWindo
           msgIsNew = false;
         }
         // note that delete falls through to move.
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
         case nsMsgFilterAction::MoveToFolder:
         {
           // if moving to a different file, do it.
diff --git a/mailnews/imap/src/nsImapProtocol.cpp b/mailnews/imap/src/nsImapProtocol.cpp
index 97e61a40ef..3839fade69 100644
--- a/mailnews/imap/src/nsImapProtocol.cpp
+++ b/mailnews/imap/src/nsImapProtocol.cpp
@@ -2775,7 +2775,7 @@ void nsImapProtocol::ProcessSelectedStateURL()
       case nsIImapUrl::nsImapExpungeFolder:
         Expunge();
         // note fall through to next cases.
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case nsIImapUrl::nsImapSelectFolder:
       case nsIImapUrl::nsImapSelectNoopFolder:
         if (!moreHeadersToDownload)
@@ -5624,7 +5624,7 @@ void nsImapProtocol::InitPrefAuthMethods(int32_t authMethodPrefValue)
         MOZ_LOG(IMAP, LogLevel::Error,
             ("IMAP: bad pref authMethod = %d\n", authMethodPrefValue));
         // fall to any
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case nsMsgAuthMethod::anything:
         m_prefAuthMethods = kHasAuthOldLoginCapability |
             kHasAuthLoginCapability | kHasAuthPlainCapability |
diff --git a/mailnews/local/src/nsParseMailbox.cpp b/mailnews/local/src/nsParseMailbox.cpp
index da51c03227..3c5dfa02aa 100644
--- a/mailnews/local/src/nsParseMailbox.cpp
+++ b/mailnews/local/src/nsParseMailbox.cpp
@@ -2026,7 +2026,7 @@ NS_IMETHODIMP nsParseNewMailState::ApplyFilterHit(nsIMsgFilter *filter, nsIMsgWi
         }
 
         // FALLTHROUGH
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case nsMsgFilterAction::MoveToFolder:
         // if moving to a different file, do it.
         if (actionTargetFolderUri.get() && !m_inboxUri.Equals(actionTargetFolderUri,
diff --git a/mailnews/local/src/nsPop3Protocol.cpp b/mailnews/local/src/nsPop3Protocol.cpp
index de129a494e..c89867a9d6 100644
--- a/mailnews/local/src/nsPop3Protocol.cpp
+++ b/mailnews/local/src/nsPop3Protocol.cpp
@@ -1639,7 +1639,7 @@ void nsPop3Protocol::InitPrefAuthMethods(int32_t authMethodPrefValue)
       MOZ_LOG(POP3LOGMODULE, LogLevel::Error,
               (POP3LOG("POP: bad pref authMethod = %d\n"), authMethodPrefValue));
       // fall to any
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case nsMsgAuthMethod::anything:
       m_prefAuthMethods = POP3_HAS_AUTH_USER |
           POP3_HAS_AUTH_LOGIN | POP3_HAS_AUTH_PLAIN |
@@ -1802,7 +1802,7 @@ int32_t nsPop3Protocol::ProcessAuth()
         break;
       case POP3_HAS_AUTH_CRAM_MD5:
         MOZ_LOG(POP3LOGMODULE, LogLevel::Debug, (POP3LOG("POP CRAM")));
-        MOZ_FALLTHROUGH;
+        [[fallthrough]];
       case POP3_HAS_AUTH_PLAIN:
       case POP3_HAS_AUTH_USER:
         MOZ_LOG(POP3LOGMODULE, LogLevel::Debug, (POP3LOG("POP username")));
diff --git a/mailnews/mime/src/mimemsig.cpp b/mailnews/mime/src/mimemsig.cpp
index 5b4f8e556a..1ad78f3ed9 100644
--- a/mailnews/mime/src/mimemsig.cpp
+++ b/mailnews/mime/src/mimemsig.cpp
@@ -256,7 +256,7 @@ MimeMultipartSigned_parse_line (const char *line, int32_t length, MimeObject *ob
     mult->hdrs = 0;
 
     /* fall through. */
-   MOZ_FALLTHROUGH;
+   [[fallthrough]];
   case MimeMultipartSignedBodyFirstHeader:
   case MimeMultipartSignedBodyHeaders:
   case MimeMultipartSignedBodyLine:
@@ -406,7 +406,7 @@ MimeMultipartSigned_parse_line (const char *line, int32_t length, MimeObject *ob
     }
 
     /* fall through. */
-   MOZ_FALLTHROUGH;
+   [[fallthrough]];
   case MimeMultipartSignedSignatureLine:
     if (hash_line_p)
     {
@@ -497,7 +497,7 @@ MimeMultipartSigned_parse_child_line (MimeObject *obj,
   case MimeMultipartSignedBodyHeaders:
     // How'd we get here?  Oh well, fall through.
     NS_ERROR("wrong state in parse child line");
-    MOZ_FALLTHROUGH;
+    [[fallthrough]];
   case MimeMultipartSignedBodyFirstLine:
     PR_ASSERT(first_line_p);
     if (!sig->part_buffer)
@@ -507,7 +507,7 @@ MimeMultipartSigned_parse_child_line (MimeObject *obj,
       return MIME_OUT_OF_MEMORY;
     }
     /* fall through */
-   MOZ_FALLTHROUGH;
+   [[fallthrough]];
   case MimeMultipartSignedBodyLine:
     {
     /* This is the first part; we are buffering it, and will emit it all
@@ -551,7 +551,7 @@ MimeMultipartSigned_parse_child_line (MimeObject *obj,
   case MimeMultipartSignedSignatureHeaders:
     // How'd we get here?  Oh well, fall through.
     NS_ERROR("should have already parse sig hdrs");
-    MOZ_FALLTHROUGH;
+    [[fallthrough]];
   case MimeMultipartSignedSignatureFirstLine:
   case MimeMultipartSignedSignatureLine:
     /* Nothing to do here -- hashing of the signature part is handled up
diff --git a/mailnews/news/src/nsNNTPProtocol.cpp b/mailnews/news/src/nsNNTPProtocol.cpp
index 035dff6e6f..c5a426947d 100644
--- a/mailnews/news/src/nsNNTPProtocol.cpp
+++ b/mailnews/news/src/nsNNTPProtocol.cpp
@@ -4549,12 +4549,12 @@ nsresult nsNNTPProtocol::ProcessProtocolState(nsIURI * url, nsIInputStream * inp
       FinishMemCacheEntry(false);  // cleanup mem cache entry
       if (m_responseCode != MK_NNTP_RESPONSE_ARTICLE_NOTFOUND && m_responseCode != MK_NNTP_RESPONSE_ARTICLE_NONEXIST)
         return CloseConnection();
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case NEWS_FREE:
       // Remember when we last used this connection
       m_lastActiveTimeStamp = PR_Now();
       CleanupAfterRunningUrl();
-      MOZ_FALLTHROUGH;
+      [[fallthrough]];
     case NNTP_SUSPENDED:
       return NS_OK;
       break;