diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/imap/src/nsImapProtocol.cpp | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | uxp-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/imap/src/nsImapProtocol.cpp')
| -rw-r--r-- | mailnews/imap/src/nsImapProtocol.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/mailnews/imap/src/nsImapProtocol.cpp b/mailnews/imap/src/nsImapProtocol.cpp index 1d0c98d48b..bf00e02065 100644 --- a/mailnews/imap/src/nsImapProtocol.cpp +++ b/mailnews/imap/src/nsImapProtocol.cpp @@ -1057,7 +1057,7 @@ void nsImapProtocol::ReleaseUrlState(bool rerunning) class nsImapThreadShutdownEvent : public mozilla::Runnable { public: - nsImapThreadShutdownEvent(nsIThread *thread) : mThread(thread) { + explicit nsImapThreadShutdownEvent(nsIThread *thread) : mThread(thread) { } NS_IMETHOD Run() { mThread->Shutdown(); @@ -9580,7 +9580,7 @@ nsresult nsImapMockChannel::ReadFromMemCache(nsICacheEntry *entry) class nsReadFromImapConnectionFailure : public mozilla::Runnable { public: - nsReadFromImapConnectionFailure(nsImapMockChannel *aChannel) + explicit nsReadFromImapConnectionFailure(nsImapMockChannel *aChannel) : mImapMockChannel(aChannel) {} |