Issue #2342: Use [[nodiscard]] in IPDL generation and fix warnings

DOM plugin code had two warning in IPC caught by [[nodiscard]], these
were fixed in one go.

2 files changed, 7 insertions, 2 deletions

diff --git a/dom/plugins/ipc/PluginModuleParent.cpp b/dom/plugins/ipc/PluginModuleParent.cpp
index 4dff7b0f41..c4461bc901 100755
--- a/dom/plugins/ipc/PluginModuleParent.cpp
+++ b/dom/plugins/ipc/PluginModuleParent.cpp
@@ -2210,7 +2210,10 @@ PluginModuleParent::NPP_NewInternal(NPMIMEType pluginType, NPP instance,
         if (supportsAsyncRender) {
           // Prefs indicates we want async plugin rendering, make sure
           // the flash module has support.
-          CallModuleSupportsAsyncRender(&supportsAsyncRender);
+          if (!CallModuleSupportsAsyncRender(&supportsAsyncRender)) {
+            // The actual support call failed. Should not happen; abort.
+            return NS_ERROR_FAILURE;
+          }
         }
 #ifdef _WIN64
         // For 64-bit builds force windowless if the flash library doesn't support
diff --git a/dom/plugins/ipc/PluginUtilsWin.cpp b/dom/plugins/ipc/PluginUtilsWin.cpp
index db6387a511..83b91b6b29 100644
--- a/dom/plugins/ipc/PluginUtilsWin.cpp
+++ b/dom/plugins/ipc/PluginUtilsWin.cpp
@@ -34,7 +34,9 @@ public:
 

     for (auto iter = mAudioNotificationSet->ConstIter(); !iter.Done(); iter.Next()) {

       PluginModuleParent* pluginModule = iter.Get()->GetKey();

-      pluginModule->SendNPP_SetValue_NPNVaudioDeviceChangeDetails(mChangeDetails);

+      if (!pluginModule->SendNPP_SetValue_NPNVaudioDeviceChangeDetails(mChangeDetails)) {

+        // Sending of notification failed. Ignore for now.

+      }

     }

     return NS_OK;

   }