summaryrefslogtreecommitdiff
path: root/CLOBBER
diff options
context:
space:
mode:
authorJob Bautista <jobbautista9@aol.com>2023-03-19 00:08:48 +0800
committerJob Bautista <jobbautista9@aol.com>2023-03-19 00:16:46 +0800
commiteac34369607620a9c80e0472a627ae8a7ec095be (patch)
tree7aeeacf67346a912bc4cb3ef56d38cd8f5b63fb9 /CLOBBER
parent972e0410ca7df3b66d1675c8ed10a2a547a4ecbf (diff)
downloaduxp-eac34369607620a9c80e0472a627ae8a7ec095be.tar.gz
Issue #2165 - Build ICU as a shared library if we're building Spidermonkey shared.
It seems that if we're going to enable JS_SHARED_LIBRARY, we need ICU to be a shared library too in order to prevent code duplication in mozjs.dll bloating it to a whopping 21 MB. This unfortunately means we have to fold icudata back to icu itself. But since icudata is still separated from libxul (which is what really matters for #1451), I think this is a fair compromise. Building ICU as shared is offered as an option via --enable-shared-icu. But technically you really need --enable-shared-icu if you're going to use --enable-shared-js. Unfortunately I can't make configure exit with an error if MOZ_SHARED_ICU is not defined when JS_SHARED_LIBRARY is enabled, because options are controlled by different configure scripts (icu is based on bash, while js is based on python), and I have no idea how to pass MOZ_SHARED_ICU to js's moz.configure. Tag #62
Diffstat (limited to 'CLOBBER')
-rw-r--r--CLOBBER2
1 files changed, 1 insertions, 1 deletions
diff --git a/CLOBBER b/CLOBBER
index 4b59135e5f..2b72302d52 100644
--- a/CLOBBER
+++ b/CLOBBER
@@ -22,4 +22,4 @@
# changes to stick? As of bug 928195, this shouldn't be necessary! Please
# don't change CLOBBER for WebIDL changes any more.
-Clobber for NSPR 4.35 and NSS 3.79.4 update \ No newline at end of file
+Touching ICU's build system requires a CLOBBER. (Issue #2165)