From c384fa6e25b07b37e9cc406da0c0aef583c61513 Mon Sep 17 00:00:00 2001 From: Gaming4JC Date: Sun, 16 Aug 2020 14:05:16 -0400 Subject: Issue #1620 - Intrinsic Aspect Ratio: Debug Follow up. Newly introduced aspect-ratio property did not have CSS_PROP_LIST_EXCLUDE_INTERNAL defines, resulting in the following assertion: \!nsCSSProps::PropHasFlags(p, (1<<28)) (properties defined outside of #ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL sections must not have the CSS_PROPERTY_INTERNAL flag), at ...layout/style/nsCSSProps.cpp:289 This patch resolves the assertion by adding #ifndef around the aspect-ratio property. --- layout/style/nsCSSPropList.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/layout/style/nsCSSPropList.h b/layout/style/nsCSSPropList.h index 44bd44cef4..f62aa38272 100644 --- a/layout/style/nsCSSPropList.h +++ b/layout/style/nsCSSPropList.h @@ -470,6 +470,7 @@ CSS_PROP_DISPLAY( kAppearanceKTable, CSS_PROP_NO_OFFSET, eStyleAnimType_Discrete) +#ifndef CSS_PROP_LIST_EXCLUDE_INTERNAL CSS_PROP_POSITION( aspect-ratio, aspect_ratio, @@ -481,6 +482,7 @@ CSS_PROP_POSITION( nullptr, offsetof(nsStylePosition, mAspectRatio), eStyleAnimType_None) +#endif // CSS_PROP_LIST_EXCLUDE_INTERNAL CSS_PROP_DISPLAY( backface-visibility, backface_visibility, -- cgit v1.2.3