diff options
Diffstat (limited to 'js/src')
-rw-r--r-- | js/src/builtin/Reflect.cpp | 10 | ||||
-rw-r--r-- | js/src/builtin/TestingFunctions.cpp | 4 | ||||
-rw-r--r-- | js/src/frontend/Parser.cpp | 4 | ||||
-rw-r--r-- | js/src/shell/js.cpp | 6 |
4 files changed, 9 insertions, 15 deletions
diff --git a/js/src/builtin/Reflect.cpp b/js/src/builtin/Reflect.cpp index ab7cca174d..a902c90d8b 100644 --- a/js/src/builtin/Reflect.cpp +++ b/js/src/builtin/Reflect.cpp @@ -44,7 +44,7 @@ Reflect_defineProperty(JSContext* cx, unsigned argc, Value* vp) ObjectOpResult result; if (!DefineProperty(cx, obj, key, desc, result)) return false; - args.rval().setBoolean(bool(result)); + args.rval().setBoolean(result.confirmOk()); return true; } @@ -69,7 +69,7 @@ Reflect_deleteProperty(JSContext* cx, unsigned argc, Value* vp) ObjectOpResult result; if (!DeleteProperty(cx, target, key, result)) return false; - args.rval().setBoolean(bool(result)); + args.rval().setBoolean(result.confirmOk()); return true; } @@ -178,7 +178,7 @@ Reflect_preventExtensions(JSContext* cx, unsigned argc, Value* vp) ObjectOpResult result; if (!PreventExtensions(cx, target, result)) return false; - args.rval().setBoolean(bool(result)); + args.rval().setBoolean(result.confirmOk()); return true; } @@ -207,7 +207,7 @@ Reflect_set(JSContext* cx, unsigned argc, Value* vp) RootedValue value(cx, args.get(2)); if (!SetProperty(cx, target, key, value, receiver, result)) return false; - args.rval().setBoolean(bool(result)); + args.rval().setBoolean(result.confirmOk()); return true; } @@ -240,7 +240,7 @@ Reflect_setPrototypeOf(JSContext* cx, unsigned argc, Value* vp) ObjectOpResult result; if (!SetPrototype(cx, obj, proto, result)) return false; - args.rval().setBoolean(bool(result)); + args.rval().setBoolean(result.confirmOk()); return true; } diff --git a/js/src/builtin/TestingFunctions.cpp b/js/src/builtin/TestingFunctions.cpp index c9dcadaddf..f91a53eae2 100644 --- a/js/src/builtin/TestingFunctions.cpp +++ b/js/src/builtin/TestingFunctions.cpp @@ -123,11 +123,7 @@ GetBuildConfiguration(JSContext* cx, unsigned argc, Value* vp) if (!JS_SetProperty(cx, info, "debug", value)) return false; -#ifdef RELEASE_OR_BETA value = BooleanValue(true); -#else - value = BooleanValue(false); -#endif if (!JS_SetProperty(cx, info, "release_or_beta", value)) return false; diff --git a/js/src/frontend/Parser.cpp b/js/src/frontend/Parser.cpp index c51545f1b9..38bd77ead3 100644 --- a/js/src/frontend/Parser.cpp +++ b/js/src/frontend/Parser.cpp @@ -10190,7 +10190,9 @@ Parser<ParseHandler>::exprInParens(InHandling inHandling, YieldHandling yieldHan bool ParserBase::warnOnceAboutExprClosure() { -#ifndef RELEASE_OR_BETA + // We extensively use expression closures. + // Disabling spew; see Issue #3061 +#if 0 JSContext* cx = context->maybeJSContext(); if (!cx) return true; diff --git a/js/src/shell/js.cpp b/js/src/shell/js.cpp index 6e155d3ff6..755fb73f1a 100644 --- a/js/src/shell/js.cpp +++ b/js/src/shell/js.cpp @@ -145,13 +145,9 @@ static const size_t gMaxStackSize = 128 * sizeof(size_t) * 1024; */ static const double MAX_TIMEOUT_SECONDS = 1800.0; -// SharedArrayBuffer and Atomics settings track Firefox. Choose a custom setting +// SharedArrayBuffer and Atomics settings track browser. Choose a custom setting // with --shared-memory={on,off}. -#ifndef RELEASE_OR_BETA # define SHARED_MEMORY_DEFAULT 1 -#else -# define SHARED_MEMORY_DEFAULT 0 -#endif using JobQueue = GCVector<JSObject*, 0, SystemAllocPolicy>; |