diff options
| author | athenian200 <athenian200@outlook.com> | 2019-10-07 03:27:01 -0500 |
|---|---|---|
| committer | athenian200 <athenian200@outlook.com> | 2019-10-21 04:53:44 -0500 |
| commit | 7d65eb2b3a345abe22f42361e00c97da2e968009 (patch) | |
| tree | 892ec22e404797b68ed9a5026fd48609f73fc547 /widget | |
| parent | 5a4a4990cd9f5d0b56d515b0246bc09da7109eb3 (diff) | |
| download | uxp-7d65eb2b3a345abe22f42361e00c97da2e968009.tar.gz | |
MoonchildProductions#1251 - Part 22: Remove some unused type declarations from IPC process_util.
https://bugzilla.mozilla.org/show_bug.cgi?id=1397928
Was looking into that _POSIX_PATH_MAX/NAME_MAX issue earlier because it didn't make a lot of sense and I was thinking of other approaches besides char arrays, and I wanted to make sure it didn't cause problems after they did it. Turns out that one commit after this was added, Mozilla determined the code I was working on fixing to be dead code as of Firefox 58. I don't know if it's dead code in Pale Moon as well, but given that it compiles fine without it and I can't find any other references to szExeFile in the IPC code, that seems like a safe bet.
Besides, I determined config/pathsub.c already seems to do what this code looks like it's trying to do, and implements the solution of just defining NAME_MAX to 256 and having done with it that I nearly adopted after realizing that even OS/2 and BeOS, let alone Unix/Linux systems, all basically use that value and there's just disagreement on which system header to check for it.
Diffstat (limited to 'widget')
| -rw-r--r-- | widget/GfxInfoX11.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/widget/GfxInfoX11.cpp b/widget/GfxInfoX11.cpp index 98a4bb9656..05a2cab1a1 100644 --- a/widget/GfxInfoX11.cpp +++ b/widget/GfxInfoX11.cpp @@ -192,7 +192,7 @@ GfxInfo::GetData() // and a buffer as some kind of workaround. They've been implementing // missing functions lately, though, so this may not be needed much longer. -#if defined(XP_SOLARIS) +#ifndef strcasestr #define strcasestr PL_strcasestr #endif |