[network] Make several variables atomic in nsSocketTransport2.

Fixes potential thread races between:
- nsSocketTransport::OnInputClosed and nsSocketTransport::OpenInputStream.
- nsSocketTransport::OnOutputClosed and nsSocketTransport::OpenOutputStream.
- nsSocketTransport::Close and nsSocketTransport::RecoverFromError called from
  OnSocketDetached.

1 files changed, 4 insertions, 3 deletions

diff --git a/netwerk/base/nsSocketTransport2.h b/netwerk/base/nsSocketTransport2.h
index 310cc58d3b..60084d53e2 100644
--- a/netwerk/base/nsSocketTransport2.h
+++ b/netwerk/base/nsSocketTransport2.h
@@ -306,6 +306,9 @@ private:
     uint16_t         SocketPort() { return (!mProxyHost.IsEmpty() && !mProxyTransparent) ? mProxyPort : mPort; }
     const nsCString &SocketHost() { return (!mProxyHost.IsEmpty() && !mProxyTransparent) ? mProxyHost : mHost; }
 
+    Atomic<bool> mInputClosed = true;

+    Atomic<bool> mOutputClosed = true;

+
     //-------------------------------------------------------------------------
     // members accessible only on the socket transport thread:
     //  (the exception being initialization/shutdown time)
@@ -314,8 +317,6 @@ private:
     // socket state vars:
     uint32_t     mState;     // STATE_??? flags
     bool mAttached;
-    bool mInputClosed;
-    bool mOutputClosed;
 
     // The platform-specific network interface id that this socket
     // associated with.
@@ -455,7 +456,7 @@ private:
     int32_t mKeepaliveRetryIntervalS;
     int32_t mKeepaliveProbeCount;
 
-    bool mDoNotRetryToConnect;
+    Atomic<bool> mDoNotRetryToConnect = false;
 };
 
 } // namespace net