diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2019-11-10 19:11:03 -0500 |
| commit | 201683afe4596ae32f7b1ea12dfca52995d59f9d (patch) | |
| tree | 8632173f59a85d1c3bf679653de7957a59c96eae /mailnews/base/search | |
| parent | 4db1ae892bad565e8e59ec6034b4c98946077248 (diff) | |
| download | uxp-201683afe4596ae32f7b1ea12dfca52995d59f9d.tar.gz | |
Bug 1487082 - Resolve potential for build bustage regarding bad implicit conversion constructors
* Part 1: make conversion CTORs explicit.
Minor tweaks to conform with new(ish) static analysis rule which flags up implicit single-argument conversion constructors.
* Part 2: fix a couple of double-mRefCnt declaration errors.
* Part 3: Fix unsafe use of NS_ConvertASCIItoUTF16().
Tag #1273
Diffstat (limited to 'mailnews/base/search')
| -rw-r--r-- | mailnews/base/search/public/nsMsgResultElement.h | 2 | ||||
| -rw-r--r-- | mailnews/base/search/public/nsMsgSearchBoolExpression.h | 2 | ||||
| -rw-r--r-- | mailnews/base/search/src/nsMsgSearchValue.h | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/mailnews/base/search/public/nsMsgResultElement.h b/mailnews/base/search/public/nsMsgResultElement.h index 3844362990..f8cdf4404f 100644 --- a/mailnews/base/search/public/nsMsgResultElement.h +++ b/mailnews/base/search/public/nsMsgResultElement.h @@ -20,7 +20,7 @@ class nsMsgResultElement { public: - nsMsgResultElement (nsIMsgSearchAdapter *); + explicit nsMsgResultElement (nsIMsgSearchAdapter *); virtual ~nsMsgResultElement (); static nsresult AssignValues (nsIMsgSearchValue *src, nsMsgSearchValue *dst); diff --git a/mailnews/base/search/public/nsMsgSearchBoolExpression.h b/mailnews/base/search/public/nsMsgSearchBoolExpression.h index c65e5c24a9..9c6a9c8d83 100644 --- a/mailnews/base/search/public/nsMsgSearchBoolExpression.h +++ b/mailnews/base/search/public/nsMsgSearchBoolExpression.h @@ -41,7 +41,7 @@ class nsMsgSearchBoolExpression public: // create a leaf node expression - nsMsgSearchBoolExpression(nsIMsgSearchTerm * aNewTerm, + explicit nsMsgSearchBoolExpression(nsIMsgSearchTerm * aNewTerm, char * aEncodingString = NULL); // create a non-leaf node expression containing 2 expressions diff --git a/mailnews/base/search/src/nsMsgSearchValue.h b/mailnews/base/search/src/nsMsgSearchValue.h index ef50ad1edd..3d08d27fa4 100644 --- a/mailnews/base/search/src/nsMsgSearchValue.h +++ b/mailnews/base/search/src/nsMsgSearchValue.h @@ -11,7 +11,7 @@ class nsMsgSearchValueImpl : public nsIMsgSearchValue { public: - nsMsgSearchValueImpl(nsMsgSearchValue *aInitialValue); + explicit nsMsgSearchValueImpl(nsMsgSearchValue *aInitialValue); NS_DECL_ISUPPORTS NS_DECL_NSIMSGSEARCHVALUE |