diff options
| author | Matt A. Tobin <email@mattatobin.com> | 2020-04-16 19:59:10 -0400 |
|---|---|---|
| committer | Matt A. Tobin <email@mattatobin.com> | 2020-04-16 19:59:10 -0400 |
| commit | 2f59167e65132fc652456ae8629c1246a9b4b2cb (patch) | |
| tree | d6f5779a031f2c957612dd4f0dd0d6ee166f9a8b /dom/xul | |
| parent | 4630e4abb531e416f8153846d422794de20261bd (diff) | |
| download | uxp-2f59167e65132fc652456ae8629c1246a9b4b2cb.tar.gz | |
Bug 656197 - Push state updates further out across beforesetattr/aftersetattr
* Remove the generic attr preparsing mechanism from BeforeSetAttr and just preparse class attributes directly in the one place that needs to do it
* Move calls to BeforeSetAttr to after AttributeWillChange
* Remove UpdateState calls in BeforeSetAttr
* Move calls to AfterSetAttr to before UpdateState when manipulating attributes
* Remove UpdateState calls from AfterSetAttr, since they are no longer needed there
Tag #1375
Diffstat (limited to 'dom/xul')
| -rw-r--r-- | dom/xul/nsXULElement.cpp | 2 | ||||
| -rw-r--r-- | dom/xul/nsXULElement.h | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/dom/xul/nsXULElement.cpp b/dom/xul/nsXULElement.cpp index c7a5393707..e96bbeef44 100644 --- a/dom/xul/nsXULElement.cpp +++ b/dom/xul/nsXULElement.cpp @@ -1007,7 +1007,7 @@ nsXULElement::UnregisterAccessKey(const nsAString& aOldValue) nsresult nsXULElement::BeforeSetAttr(int32_t aNamespaceID, nsIAtom* aName, - nsAttrValueOrString* aValue, bool aNotify) + const nsAttrValueOrString* aValue, bool aNotify) { if (aNamespaceID == kNameSpaceID_None && aName == nsGkAtoms::accesskey && IsInUncomposedDoc()) { diff --git a/dom/xul/nsXULElement.h b/dom/xul/nsXULElement.h index 109f6c2e75..c2dcadf5f8 100644 --- a/dom/xul/nsXULElement.h +++ b/dom/xul/nsXULElement.h @@ -624,7 +624,7 @@ protected: nsresult MakeHeavyweight(nsXULPrototypeElement* aPrototype); virtual nsresult BeforeSetAttr(int32_t aNamespaceID, nsIAtom* aName, - nsAttrValueOrString* aValue, + const nsAttrValueOrString* aValue, bool aNotify) override; virtual nsresult AfterSetAttr(int32_t aNamespaceID, nsIAtom* aName, const nsAttrValue* aValue, bool aNotify) override; |