summaryrefslogtreecommitdiff
path: root/dom/events
diff options
context:
space:
mode:
authorFranklinDM <mrmineshafter17@gmail.com>2023-03-04 02:23:31 +0800
committerFranklinDM <mrmineshafter17@gmail.com>2023-03-04 21:32:10 +0800
commita69e82b0d7d0617ba1e02257bb92491cafe9470a (patch)
tree534a667d114607f7286bcb20403da14ee880c7a5 /dom/events
parent3d82baddf33f6951140b17e0c01c3901b733f041 (diff)
downloaduxp-a69e82b0d7d0617ba1e02257bb92491cafe9470a.tar.gz
Issue #2135 - Bug 1413102 (Follow-up): Ignore current target because of shadow DOM retargeting
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1466581
Diffstat (limited to 'dom/events')
-rw-r--r--dom/events/EventDispatcher.cpp7
-rw-r--r--dom/events/EventDispatcher.h11
2 files changed, 16 insertions, 2 deletions
diff --git a/dom/events/EventDispatcher.cpp b/dom/events/EventDispatcher.cpp
index 9a48ca2a90..e2b5699241 100644
--- a/dom/events/EventDispatcher.cpp
+++ b/dom/events/EventDispatcher.cpp
@@ -872,6 +872,7 @@ EventDispatcher::Dispatch(nsISupports* aTarget,
preVisitor.mTargetInKnownToBeHandledScope = preVisitor.mEvent->mTarget;
topEtci = parentEtci;
} else {
+ bool ignoreBecauseOfShadowDOM = preVisitor.mIgnoreBecauseOfShadowDOM;
nsCOMPtr<nsINode> disabledTarget = do_QueryInterface(parentTarget);
parentEtci = MayRetargetToChromeIfCanNotHandleEvent(chain,
preVisitor,
@@ -882,7 +883,11 @@ EventDispatcher::Dispatch(nsISupports* aTarget,
preVisitor.mTargetInKnownToBeHandledScope = preVisitor.mEvent->mTarget;
EventTargetChainItem* item =
EventTargetChainItem::GetFirstCanHandleEventTarget(chain);
- item->SetNewTarget(parentTarget);
+ if (!ignoreBecauseOfShadowDOM) {
+ // If we ignored the target because of Shadow DOM retargeting, we
+ // shouldn't treat the target to be in the event path at all.
+ item->SetNewTarget(parentTarget);
+ }
topEtci = parentEtci;
continue;
}
diff --git a/dom/events/EventDispatcher.h b/dom/events/EventDispatcher.h
index 529240d0ac..403c472c5c 100644
--- a/dom/events/EventDispatcher.h
+++ b/dom/events/EventDispatcher.h
@@ -128,6 +128,7 @@ public:
, mParentIsSlotInClosedTree(false)
, mParentIsChromeHandler(false)
, mRelatedTargetRetargetedInCurrentScope(false)
+ , mIgnoreBecauseOfShadowDOM(false)
, mParentTarget(nullptr)
, mEventTargetAtParent(nullptr)
, mRetargetedRelatedTarget(nullptr)
@@ -151,6 +152,7 @@ public:
// Note, we don't clear mRelatedTargetRetargetedInCurrentScope explicitly,
// since it is used during event path creation to indicate whether
// relatedTarget may need to be retargeted.
+ mIgnoreBecauseOfShadowDOM = false;
mParentTarget = nullptr;
mEventTargetAtParent = nullptr;
mRetargetedRelatedTarget = nullptr;
@@ -169,9 +171,10 @@ public:
}
}
- void IgnoreCurrentTarget()
+ void IgnoreCurrentTargetBecauseOfShadowDOMRetargeting()
{
mCanHandle = false;
+ mIgnoreBecauseOfShadowDOM = true;
SetParentTarget(nullptr, false);
mEventTargetAtParent = nullptr;
}
@@ -251,6 +254,12 @@ public:
*/
bool mRelatedTargetRetargetedInCurrentScope;
+ /**
+ * True if Shadow DOM relatedTarget retargeting causes the current item
+ * to not show up in the event path.
+ */
+ bool mIgnoreBecauseOfShadowDOM;
+
private:
/**
* Parent item in the event target chain.