Issue #1821 - Restore "dot" indicators

This also removes orange compat warning styling and associated strings.

Reverses the entirety of #1445

15 files changed, 25 insertions, 52 deletions

diff --git a/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd b/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
index 098896d99e..9ec6eaa12d 100644
--- a/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
+++ b/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd
@@ -207,6 +207,9 @@
 <!ENTITY addon.loadingReleaseNotes.label      "Loading…">
 <!ENTITY addon.errorLoadingReleaseNotes.label "Sorry, but there was an error loading the release notes.">
 
+<!ENTITY addon.nativeAddon                    "This add-on directly targets &brandFullName;">
+<!ENTITY addon.compatAddon                    "This add-on targets Mozilla Firefox and runs in compatibility mode">
+
 <!ENTITY addon.createdBy.label                "By ">
 
 <!ENTITY eula.title                           "End-User License Agreement">
diff --git a/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties b/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties
index 0b5ec69a18..370198f569 100644
--- a/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties
+++ b/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.properties
@@ -30,9 +30,6 @@ notification.blocked.link=More Information
 #LOCALIZATION NOTE (notification.softblocked) %1$S is the add-on name
 notification.softblocked=%1$S is known to cause issues.
 notification.softblocked.link=More Information
-#LOCALIZATION NOTE (notification.compatibility) %1$S is the add-on name, %2$S is brand name
-notification.compatibility=%1$S was not designed for %2$S. It may not function properly or cease to function.
-notification.compatibility.link=More Information
 #LOCALIZATION NOTE (notification.outdated) %1$S is the add-on name
 notification.outdated=An important update is available for %1$S.
 notification.outdated.link=Update Now
@@ -81,9 +78,6 @@ details.notification.incompatible=%1$S is incompatible with %2$S %3$S.
 #LOCALIZATION NOTE (details.notification.blocked) %1$S is the add-on name
 details.notification.blocked=%1$S has been disabled due to security or stability issues.
 details.notification.blocked.link=More Information
-#LOCALIZATION NOTE (details.notification.compatibility) %1$S is the add-on name, %2$S is brand name
-details.notification.compatibility=%1$S was not designed for %2$S. It may not function properly or cease to function.
-details.notification.compatibility.link=More Information
 #LOCALIZATION NOTE (details.notification.softblocked) %1$S is the add-on name
 details.notification.softblocked=%1$S is known to cause issues.
 details.notification.softblocked.link=More Information
diff --git a/toolkit/mozapps/extensions/content/extensions.css b/toolkit/mozapps/extensions/content/extensions.css
index 51828d544c..41c1405657 100644
--- a/toolkit/mozapps/extensions/content/extensions.css
+++ b/toolkit/mozapps/extensions/content/extensions.css
@@ -152,6 +152,8 @@ setting[type="menulist"] {
 .addon:not([notification="info"]) .info,
 .addon:not([pending]) .pending,
 .addon:not([upgrade="true"]) .update-postfix,
+.addon:not([native="true"]) .nativeAddon,
+.addon:not([native="false"]) .compatAddon,
 .addon[active="true"] .disabled-postfix,
 .addon[pending="install"] .update-postfix,
 .addon[pending="install"] .disabled-postfix,
@@ -264,6 +266,21 @@ richlistitem:not([selected]) * {
   display: none;
 }
 
+/* Indicator style for extension target application */
+.addon[native] .nativeIndicator {
+  margin-left: 5pt;
+  padding-bottom: 1pt;
+}
+.addon[native][active="false"] .nativeIndicator {
+  opacity: 0.4;
+}
+.addon[native] .nativeAddon {
+  color: #3366FF;
+}
+.addon[native] .compatAddon {
+  color: #FF6600;
+}
+
 /* Translators for Language Pack details */
 .translators > label {
   -moz-margin-start: 0px;
diff --git a/toolkit/mozapps/extensions/content/extensions.js b/toolkit/mozapps/extensions/content/extensions.js
index 1c800ef649..fe84bc4602 100644
--- a/toolkit/mozapps/extensions/content/extensions.js
+++ b/toolkit/mozapps/extensions/content/extensions.js
@@ -3043,19 +3043,6 @@ var gDetailView = {
         warning.textContent =
           gStrings.ext.formatStringFromName("details.notification.gmpPending",
                                             [this._addon.name], 1);
-#ifdef MOZ_PHOENIX_EXTENSIONS
-      } else if (this._addon.native == false) {
-        this.node.setAttribute("notification", "warning");
-        this.node.setAttribute("native", "false");
-        document.getElementById("detail-warning").textContent = gStrings.ext.formatStringFromName(
-          "details.notification.compatibility",
-          [this._addon.name, gStrings.brandShortName], 2
-        );
-        var warningLink = document.getElementById("detail-warning-link");
-        warningLink.value = gStrings.ext.GetStringFromName("details.notification.compatibility.link");
-        warningLink.href = Services.urlFormatter.formatURLPref("extensions.compatibility.url");
-        warningLink.hidden = false;
-#endif
       } else {
         this.node.removeAttribute("notification");
       }
diff --git a/toolkit/mozapps/extensions/content/extensions.xml b/toolkit/mozapps/extensions/content/extensions.xml
index fc19be4b3a..28feb19698 100644
--- a/toolkit/mozapps/extensions/content/extensions.xml
+++ b/toolkit/mozapps/extensions/content/extensions.xml
@@ -857,6 +857,10 @@
                 <xul:label anonid="name" class="name" crop="end" flex="1"
                            xbl:inherits="value=name,tooltiptext=name"/>
                 <xul:label anonid="version" class="version"/>
+#ifdef MOZ_PHOENIX_EXTENSIONS
+                <xul:label class="nativeIndicator nativeAddon" value="●" tooltiptext="&addon.nativeAddon;"/>
+                <xul:label class="nativeIndicator compatAddon" value="●" tooltiptext="&addon.compatAddon;"/>
+#endif
                 <xul:label class="disabled-postfix" value="&addon.disabled.postfix;"/>
                 <xul:label class="update-postfix" value="&addon.update.postfix;"/>
                 <xul:spacer flex="5000"/> <!-- Necessary to make the name crop -->
@@ -1353,20 +1357,8 @@
             } else {
               this.removeAttribute("notification");
 #ifdef MOZ_PHOENIX_EXTENSIONS
-              if (this.mAddon.type == "extension") {
+              if (this.mAddon.type == "extension")
                 this.setAttribute("native", this.mAddon.native);
-                if (this.mAddon.native == false) {
-                  this.setAttribute("notification", "warning");
-                  this._warning.textContent = gStrings.ext.formatStringFromName(
-                    "notification.compatibility",
-                    [this.mAddon.name, gStrings.brandShortName], 2
-                  );
-                  this._warningLink.value = gStrings.ext.GetStringFromName("notification.compatibility.link");
-                  this._warningLink.href = Services.urlFormatter.formatURLPref("extensions.compatibility.url");
-                  this._warningLink.hidden = false;
-                  this._warningBtn.hidden = true;
-                }
-              }
 #endif
             }
           }
diff --git a/toolkit/themes/linux/mozapps/extensions/extensions.css b/toolkit/themes/linux/mozapps/extensions/extensions.css
index b21a655203..5c642fbbf1 100644
--- a/toolkit/themes/linux/mozapps/extensions/extensions.css
+++ b/toolkit/themes/linux/mozapps/extensions/extensions.css
@@ -517,13 +517,6 @@
   background-repeat: repeat-x;
 }
 
-.addon-view[notification="warning"][native="false"] {
-  background-image: url("chrome://mozapps/skin/extensions/stripes-compatibility.png"),
-                    linear-gradient(rgba(255, 128, 0, 0.04),
-                                    rgba(255, 128, 0, 0));
-  background-repeat: repeat-x;
-}
-
 .addon-view[notification="error"] {
   background-image: url("chrome://mozapps/skin/extensions/stripes-error.png"),
                     linear-gradient(rgba(255, 0, 0, 0.04),
diff --git a/toolkit/themes/linux/mozapps/extensions/stripes-compatibility.png b/toolkit/themes/linux/mozapps/extensions/stripes-compatibility.png
deleted file mode 100644
index dee75516b7..0000000000
--- a/toolkit/themes/linux/mozapps/extensions/stripes-compatibility.png
+++ /dev/null
diff --git a/toolkit/themes/linux/mozapps/extensions/stripes-error.png b/toolkit/themes/linux/mozapps/extensions/stripes-error.png
deleted file mode 100644
index 1dc2d8504c..0000000000
--- a/toolkit/themes/linux/mozapps/extensions/stripes-error.png
+++ /dev/null
diff --git a/toolkit/themes/linux/mozapps/extensions/stripes-info-negative.png b/toolkit/themes/linux/mozapps/extensions/stripes-info-negative.png
deleted file mode 100644
index 901ab1ec29..0000000000
--- a/toolkit/themes/linux/mozapps/extensions/stripes-info-negative.png
+++ /dev/null
diff --git a/toolkit/themes/linux/mozapps/extensions/stripes-info-positive.png b/toolkit/themes/linux/mozapps/extensions/stripes-info-positive.png
deleted file mode 100644
index 370ceec0f2..0000000000
--- a/toolkit/themes/linux/mozapps/extensions/stripes-info-positive.png
+++ /dev/null
diff --git a/toolkit/themes/linux/mozapps/extensions/stripes-warning.png b/toolkit/themes/linux/mozapps/extensions/stripes-warning.png
deleted file mode 100644
index 69463fb1af..0000000000
--- a/toolkit/themes/linux/mozapps/extensions/stripes-warning.png
+++ /dev/null
diff --git a/toolkit/themes/linux/mozapps/jar.mn b/toolkit/themes/linux/mozapps/jar.mn
index 27b6473084..0931d1823d 100644
--- a/toolkit/themes/linux/mozapps/jar.mn
+++ b/toolkit/themes/linux/mozapps/jar.mn
@@ -26,11 +26,6 @@ toolkit.jar:
   skin/classic/mozapps/extensions/themeGeneric.png         (extensions/themeGeneric.png)
   skin/classic/mozapps/extensions/themeGeneric-16.png      (extensions/themeGeneric-16.png)
   skin/classic/mozapps/extensions/localeGeneric.png        (extensions/localeGeneric.png)
-  skin/classic/mozapps/extensions/stripes-warning.png        (extensions/stripes-warning.png)
-  skin/classic/mozapps/extensions/stripes-compatibility.png  (extensions/stripes-compatibility.png)
-  skin/classic/mozapps/extensions/stripes-error.png          (extensions/stripes-error.png)
-  skin/classic/mozapps/extensions/stripes-info-positive.png  (extensions/stripes-info-positive.png)
-  skin/classic/mozapps/extensions/stripes-info-negative.png  (extensions/stripes-info-negative.png)
   skin/classic/mozapps/extensions/newaddon.css             (extensions/newaddon.css)
   skin/classic/mozapps/extensions/selectAddons.css         (extensions/selectAddons.css)
   skin/classic/mozapps/xpinstall/xpinstallItemGeneric.png  (extensions/extensionGeneric.png)
diff --git a/toolkit/themes/windows/mozapps/extensions/extensions.css b/toolkit/themes/windows/mozapps/extensions/extensions.css
index 96ea1b46ce..f350f7ca64 100644
--- a/toolkit/themes/windows/mozapps/extensions/extensions.css
+++ b/toolkit/themes/windows/mozapps/extensions/extensions.css
@@ -648,13 +648,6 @@
   background-repeat: repeat-x;
 }
 
-.addon-view[notification="warning"][native="false"] {
-  background-image: url("chrome://mozapps/skin/extensions/stripes-compatibility.png"),
-                    linear-gradient(rgba(255, 128, 0, 0.04),
-                                    rgba(255, 128, 0, 0));
-  background-repeat: repeat-x;
-}
-
 .addon-view[notification="error"] {
   background-image: url("chrome://mozapps/skin/extensions/stripes-error.png"),
                     linear-gradient(rgba(255, 0, 0, 0.04),
diff --git a/toolkit/themes/windows/mozapps/extensions/stripes-compatibility.png b/toolkit/themes/windows/mozapps/extensions/stripes-compatibility.png
deleted file mode 100644
index dee75516b7..0000000000
--- a/toolkit/themes/windows/mozapps/extensions/stripes-compatibility.png
+++ /dev/null
diff --git a/toolkit/themes/windows/mozapps/jar.mn b/toolkit/themes/windows/mozapps/jar.mn
index 5ca886051c..9f7562995f 100644
--- a/toolkit/themes/windows/mozapps/jar.mn
+++ b/toolkit/themes/windows/mozapps/jar.mn
@@ -39,7 +39,6 @@ toolkit.jar:
   skin/classic/mozapps/extensions/heart.png                  (extensions/heart.png)
   skin/classic/mozapps/extensions/navigation.png             (extensions/navigation.png)
   skin/classic/mozapps/extensions/stripes-warning.png        (extensions/stripes-warning.png)
-  skin/classic/mozapps/extensions/stripes-compatibility.png  (extensions/stripes-compatibility.png)
   skin/classic/mozapps/extensions/stripes-error.png          (extensions/stripes-error.png)
   skin/classic/mozapps/extensions/stripes-info-positive.png  (extensions/stripes-info-positive.png)
   skin/classic/mozapps/extensions/stripes-info-negative.png  (extensions/stripes-info-negative.png)