diff options
author | Matt A. Tobin <email@mattatobin.com> | 2020-04-14 19:23:08 -0400 |
---|---|---|
committer | Matt A. Tobin <email@mattatobin.com> | 2020-04-14 19:23:08 -0400 |
commit | 4bd0d2e9456412a0cc6304d637c1dc85a543dee9 (patch) | |
tree | 2c25afe00fb09a1013e5deddfd9112881e95ab5f | |
parent | e518a018299ca59d8dbf36e48af815398bb1c455 (diff) | |
download | basilisk-4bd0d2e9456412a0cc6304d637c1dc85a543dee9.tar.gz |
Issue MoonchildProductions/UXP#1516 - Change CAN_DRAW_IN_TITLEBAR to MOZ_CAN_DRAW_IN_TITLEBAR except for AppConstants in CUIv2020.04.15
Also updates platform commit pointer to match
-rw-r--r-- | basilisk/base/content/browser.css | 2 | ||||
-rw-r--r-- | basilisk/base/content/browser.xul | 8 | ||||
-rw-r--r-- | basilisk/base/jar.mn | 2 | ||||
-rw-r--r-- | basilisk/base/moz.build | 3 | ||||
-rw-r--r-- | basilisk/components/customizableui/content/customizeMode.inc.xul | 2 | ||||
-rw-r--r-- | basilisk/components/customizableui/moz.build | 3 | ||||
-rw-r--r-- | basilisk/confvars.sh | 6 | ||||
-rw-r--r-- | basilisk/themes/osx/moz.build | 2 | ||||
-rw-r--r-- | basilisk/themes/shared/customizableui/customizeMode.inc.css | 6 | ||||
-rw-r--r-- | basilisk/themes/windows/moz.build | 2 | ||||
m--------- | platform | 0 |
11 files changed, 16 insertions, 20 deletions
diff --git a/basilisk/base/content/browser.css b/basilisk/base/content/browser.css index a2c2559..776cea1 100644 --- a/basilisk/base/content/browser.css +++ b/basilisk/base/content/browser.css @@ -205,7 +205,7 @@ toolbar[customizing] > .overflow-button { display: none; } -%ifdef CAN_DRAW_IN_TITLEBAR +%ifdef MOZ_CAN_DRAW_IN_TITLEBAR #main-window:not([chromemargin]) > #titlebar, #main-window[inFullscreen] > #titlebar, #main-window[inFullscreen] .titlebar-placeholder, diff --git a/basilisk/base/content/browser.xul b/basilisk/base/content/browser.xul index 91299de..176eabd 100644 --- a/basilisk/base/content/browser.xul +++ b/basilisk/base/content/browser.xul @@ -44,7 +44,7 @@ titlemodifier_normal="&mainWindow.titlemodifier;" titlemodifier_privatebrowsing="&mainWindow.titlemodifier; &mainWindow.titlePrivateBrowsingSuffix;" #endif -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR #ifdef XP_WIN chromemargin="0,2,2,2" #else @@ -387,7 +387,7 @@ onpopupshowing="UpdateDynamicShortcutTooltipText(this);"/> </popupset> -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR <vbox id="titlebar"> <hbox id="titlebar-content"> <spacer id="titlebar-spacer" flex="1"/> @@ -434,7 +434,7 @@ #include browser-menubar.inc </toolbaritem> -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR #ifndef XP_MACOSX <hbox class="titlebar-placeholder" type="caption-buttons" ordinal="1000" id="titlebar-placeholder-on-menubar-for-caption-buttons" persist="width" @@ -499,7 +499,7 @@ #if !defined(MOZ_WIDGET_GTK) <hbox class="private-browsing-indicator" skipintoolbarset="true"/> #endif -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR <hbox class="titlebar-placeholder" type="caption-buttons" id="titlebar-placeholder-on-TabsToolbar-for-captions-buttons" persist="width" #ifndef XP_MACOSX diff --git a/basilisk/base/jar.mn b/basilisk/base/jar.mn index 10a9154..464032f 100644 --- a/basilisk/base/jar.mn +++ b/basilisk/base/jar.mn @@ -76,7 +76,7 @@ browser.jar: #endif content/browser/browser-sidebar.js (content/browser-sidebar.js) * content/browser/browser-tabPreviews.xml (content/browser-tabPreviews.xml) -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR content/browser/browser-tabsintitlebar.js (content/browser-tabsintitlebar.js) #else content/browser/browser-tabsintitlebar.js (content/browser-tabsintitlebar-stub.js) diff --git a/basilisk/base/moz.build b/basilisk/base/moz.build index b21c0ac..2e5cde1 100644 --- a/basilisk/base/moz.build +++ b/basilisk/base/moz.build @@ -13,9 +13,6 @@ if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'gtk2', 'gtk3', 'cocoa'): DEFINES['HAVE_SHELL_SERVICE'] = 1 DEFINES['CONTEXT_COPY_IMAGE_CONTENTS'] = 1 -if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'cocoa'): - DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1 - if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'gtk2', 'gtk3'): DEFINES['MENUBAR_CAN_AUTOHIDE'] = 1 diff --git a/basilisk/components/customizableui/content/customizeMode.inc.xul b/basilisk/components/customizableui/content/customizeMode.inc.xul index b665630..28ce568 100644 --- a/basilisk/components/customizableui/content/customizeMode.inc.xul +++ b/basilisk/components/customizableui/content/customizeMode.inc.xul @@ -19,7 +19,7 @@ <vbox id="customization-palette" class="customization-palette"/> <spacer id="customization-spacer"/> <hbox id="customization-footer"> -#ifdef CAN_DRAW_IN_TITLEBAR +#ifdef MOZ_CAN_DRAW_IN_TITLEBAR <button id="customization-titlebar-visibility-button" class="customizationmode-button" label="&customizeMode.titlebar;" type="checkbox" #NB: because oncommand fires after click, by the time we've fired, the checkbox binding diff --git a/basilisk/components/customizableui/moz.build b/basilisk/components/customizableui/moz.build index 5797a03..f5c34aa 100644 --- a/basilisk/components/customizableui/moz.build +++ b/basilisk/components/customizableui/moz.build @@ -19,6 +19,3 @@ EXTRA_JS_MODULES += [ EXTRA_PP_JS_MODULES += [ 'CustomizableUI.jsm', ] - -if CONFIG['MOZ_WIDGET_TOOLKIT'] in ('windows', 'cocoa'): - DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1 diff --git a/basilisk/confvars.sh b/basilisk/confvars.sh index f486172..f88dab9 100644 --- a/basilisk/confvars.sh +++ b/basilisk/confvars.sh @@ -59,6 +59,12 @@ MOZ_SAFE_BROWSING= MOZ_GAMEPAD=1 MOZ_AV1=1 MOZ_SECURITY_SQLSTORE=1 + +if test "$OS_ARCH" = "WINNT" -o \ + "$OS_ARCH" = "Darwin"; then + MOZ_CAN_DRAW_IN_TITLEBAR=1 +fi + # Disable checking that add-ons are signed by the trusted root MOZ_ADDON_SIGNING=0 MOZ_REQUIRE_SIGNING=0 diff --git a/basilisk/themes/osx/moz.build b/basilisk/themes/osx/moz.build index b787ab0..8b61104 100644 --- a/basilisk/themes/osx/moz.build +++ b/basilisk/themes/osx/moz.build @@ -8,6 +8,4 @@ DIRS += ['communicator'] JAR_MANIFESTS += ['jar.mn'] -DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1 - include('../tab-svgs.mozbuild') diff --git a/basilisk/themes/shared/customizableui/customizeMode.inc.css b/basilisk/themes/shared/customizableui/customizeMode.inc.css index d999333..8535637 100644 --- a/basilisk/themes/shared/customizableui/customizeMode.inc.css +++ b/basilisk/themes/shared/customizableui/customizeMode.inc.css @@ -182,7 +182,7 @@ height: 24px; } -%ifdef CAN_DRAW_IN_TITLEBAR +%ifdef MOZ_CAN_DRAW_IN_TITLEBAR #customization-titlebar-visibility-button > .button-box > .button-text, %endif #customization-lwtheme-button > .box-inherit > .box-inherit > .button-text { @@ -198,7 +198,7 @@ background-size: contain; } -%ifdef CAN_DRAW_IN_TITLEBAR +%ifdef MOZ_CAN_DRAW_IN_TITLEBAR #customization-titlebar-visibility-button { list-style-image: url("chrome://browser/skin/customizableui/customize-titleBar-toggle.png"); -moz-image-region: rect(0, 24px, 24px, 0); @@ -222,7 +222,7 @@ -moz-image-region: rect(0, 96px, 48px, 48px); } } -%endif /* CAN_DRAW_IN_TITLEBAR */ +%endif /* MOZ_CAN_DRAW_IN_TITLEBAR */ #main-window[customize-entered] #customization-panel-container { background-image: url("chrome://browser/skin/customizableui/customizeMode-separatorHorizontal.png"), diff --git a/basilisk/themes/windows/moz.build b/basilisk/themes/windows/moz.build index b787ab0..8b61104 100644 --- a/basilisk/themes/windows/moz.build +++ b/basilisk/themes/windows/moz.build @@ -8,6 +8,4 @@ DIRS += ['communicator'] JAR_MANIFESTS += ['jar.mn'] -DEFINES['CAN_DRAW_IN_TITLEBAR'] = 1 - include('../tab-svgs.mozbuild') diff --git a/platform b/platform -Subproject 552470fb6f3e7b3028e725e0affc6e4f5550c51 +Subproject 6f6d1f6ff788b6fac2a137ecbd41762f9976f42 |