Issue %3057 - Part 9: Adjust all callsites for no longer using GetNativePath

Depending on context, various solutions were used.

14 files changed, 61 insertions, 17 deletions

diff --git a/system/interface/nsDeviceContextSpecProxy.cpp b/system/interface/nsDeviceContextSpecProxy.cpp
index df0927237..7ff3c6e97 100644
--- a/system/interface/nsDeviceContextSpecProxy.cpp
+++ b/system/interface/nsDeviceContextSpecProxy.cpp
@@ -169,7 +169,11 @@ nsDeviceContextSpecProxy::CreateUniqueTempPath(nsACString& aFilePath)
     return rv;
   }
 
+#ifdef XP_WIN
+  return recordingFile->GetPersistentDescriptor(aFilePath);
+#else
   return recordingFile->GetNativePath(aFilePath);
+#endif
 }
 
 NS_IMETHODIMP
diff --git a/system/interface/windows/WinTaskbar.cpp b/system/interface/windows/WinTaskbar.cpp
index 530cfd5b9..3c00fae7a 100644
--- a/system/interface/windows/WinTaskbar.cpp
+++ b/system/interface/windows/WinTaskbar.cpp
@@ -1,4 +1,3 @@
-/* vim: se cin sw=2 ts=2 et : */
 /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*-
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
@@ -246,7 +245,7 @@ WinTaskbar::GetAppUserModelID(nsAString & aDefaultGroupId) {
     bool exists = false;
     if (profileDir && NS_SUCCEEDED(profileDir->Exists(&exists)) && exists) {
       nsAutoCString path;
-      if (NS_SUCCEEDED(profileDir->GetNativePath(path))) {
+      if (NS_SUCCEEDED(profileDir->GetPersistentDescriptor(path))) {
         nsAutoString id;
         id.AppendInt(HashString(path));
         if (!id.IsEmpty()) {
diff --git a/system/interface/windows/nsDataObj.cpp b/system/interface/windows/nsDataObj.cpp
index 39b269d0d..81dcb8f16 100644
--- a/system/interface/windows/nsDataObj.cpp
+++ b/system/interface/windows/nsDataObj.cpp
@@ -1294,7 +1294,7 @@ nsDataObj :: GetFileContentsInternetShortcut ( FORMATETC& aFE, STGMEDIUM& aSTG )
 
     rv = mozilla::widget::FaviconHelper::GetOutputIconPath(aUri, icoFile, true);
     NS_ENSURE_SUCCESS(rv, E_FAIL);
-    rv = icoFile->GetNativePath(path);
+    rv = icoFile->GetPersistentDescriptor(path);
     NS_ENSURE_SUCCESS(rv, E_FAIL);
 
     shortcutFormatStr = "[InternetShortcut]\r\nURL=%s\r\n"
diff --git a/system/network/base/nsDirectoryIndexStream.cpp b/system/network/base/nsDirectoryIndexStream.cpp
index 87a57fd57..7b51a952d 100644
--- a/system/network/base/nsDirectoryIndexStream.cpp
+++ b/system/network/base/nsDirectoryIndexStream.cpp
@@ -1,17 +1,13 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/* vim:set sw=4 sts=4 et cin: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
-
 /*
-
   The converts a filesystem directory into an "HTTP index" stream per
   Lou Montulli's original spec:
 
   http://www.mozilla.org/projects/netlib/dirindexformat.html
-
  */
 
 #include "nsEscape.h"
@@ -92,7 +88,7 @@ nsDirectoryIndexStream::Init(nsIFile* aDir)
 
     if (MOZ_LOG_TEST(gLog, LogLevel::Debug)) {
         nsAutoCString path;
-        aDir->GetNativePath(path);
+        aDir->GetPersistentDescriptor(path);
         MOZ_LOG(gLog, LogLevel::Debug,
                ("nsDirectoryIndexStream[%p]: initialized on %s",
                 this, path.get()));
@@ -239,7 +235,7 @@ nsDirectoryIndexStream::Read(char* aBuf, uint32_t aCount, uint32_t* aReadCount)
 
             if (MOZ_LOG_TEST(gLog, LogLevel::Debug)) {
                 nsAutoCString path;
-                current->GetNativePath(path);
+                current->GetPersistentDescriptor(path);
                 MOZ_LOG(gLog, LogLevel::Debug,
                        ("nsDirectoryIndexStream[%p]: iterated %s",
                         this, path.get()));
diff --git a/system/network/base/nsStandardURL.cpp b/system/network/base/nsStandardURL.cpp
index 57337e480..083a5178b 100644
--- a/system/network/base/nsStandardURL.cpp
+++ b/system/network/base/nsStandardURL.cpp
@@ -1,5 +1,4 @@
 /* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
-/* vim:set ts=4 sw=4 sts=4 et cindent: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
@@ -3159,7 +3158,7 @@ nsStandardURL::GetFile(nsIFile **result)
 
     if (LOG_ENABLED()) {
         nsAutoCString path;
-        mFile->GetNativePath(path);
+        mFile->GetPersistentDescriptor(path);
         LOG(("nsStandardURL::GetFile [this=%p spec=%s resulting_path=%s]\n",
             this, mSpec.get(), path.get()));
     }
diff --git a/system/network/cache/nsCache.cpp b/system/network/cache/nsCache.cpp
index 7f5d6a071..b3ecfeae2 100644
--- a/system/network/cache/nsCache.cpp
+++ b/system/network/cache/nsCache.cpp
@@ -20,11 +20,19 @@ void
 CacheLogPrintPath(mozilla::LogLevel level, const char * format, nsIFile * item)
 {
     nsAutoCString path;
+#ifdef XP_WIN
+    nsresult rv = item->GetPersistentDescriptor(path);
+#else
     nsresult rv = item->GetNativePath(path);
+#endif
     if (NS_SUCCEEDED(rv)) {
         MOZ_LOG(gCacheLog, level, (format, path.get()));
     } else {
+#ifdef XP_WIN
+        MOZ_LOG(gCacheLog, level, ("GetPersistentDescriptor failed: %x", rv));
+#else
         MOZ_LOG(gCacheLog, level, ("GetNativePath failed: %x", rv));
+#endif
     }
 }
 
diff --git a/system/network/cache/nsCacheService.cpp b/system/network/cache/nsCacheService.cpp
index 6c8e5f5b8..50bf1095e 100644
--- a/system/network/cache/nsCacheService.cpp
+++ b/system/network/cache/nsCacheService.cpp
@@ -1739,7 +1739,7 @@ nsCacheService::CreateCustomOfflineDevice(nsIFile *aProfileDir,
 
     if (MOZ_LOG_TEST(gCacheLog, LogLevel::Info)) {
       nsAutoCString profilePath;
-      aProfileDir->GetNativePath(profilePath);
+      aProfileDir->GetPersistentDescriptor(profilePath);
       CACHE_LOG_INFO(("Creating custom offline device, %s, %d",
                         profilePath.BeginReading(), aQuota));
     }
@@ -3093,7 +3093,11 @@ nsCacheService::MoveOrRemoveDiskCache(nsIFile *aOldCacheDir,
         return;
     
     nsAutoCString newPath;
+#ifdef XP_WIN
+    rv = aNewCacheSubdir->GetPersistentDescriptor(newPath);
+#else
     rv = aNewCacheSubdir->GetNativePath(newPath);
+#endif
     if (NS_FAILED(rv))
         return;
         
@@ -3105,7 +3109,11 @@ nsCacheService::MoveOrRemoveDiskCache(nsIFile *aOldCacheDir,
         rv = aNewCacheDir->Create(nsIFile::DIRECTORY_TYPE, 0777);
         if (NS_SUCCEEDED(rv) || NS_ERROR_FILE_ALREADY_EXISTS == rv) {
             nsAutoCString oldPath;
+#ifdef XP_WIN
+            rv = aOldCacheSubdir->GetPersistentDescriptor(oldPath);
+#else
             rv = aOldCacheSubdir->GetNativePath(oldPath);
+#endif
             if (NS_FAILED(rv))
                 return;
             if (rename(oldPath.get(), newPath.get()) == 0)
diff --git a/system/network/cache/nsDiskCacheDeviceSQL.cpp b/system/network/cache/nsDiskCacheDeviceSQL.cpp
index 297c0f362..caacf92a2 100644
--- a/system/network/cache/nsDiskCacheDeviceSQL.cpp
+++ b/system/network/cache/nsDiskCacheDeviceSQL.cpp
@@ -287,7 +287,7 @@ nsOfflineCacheEvictionFunction::Apply()
   for (int32_t i = 0; i < items.Count(); i++) {
     if (MOZ_LOG_TEST(gCacheLog, LogLevel::Debug)) {
       nsAutoCString path;
-      items[i]->GetNativePath(path);
+      items[i]->GetPersistentDescriptor(path);
       LOG(("  removing %s\n", path.get()));
     }
 
diff --git a/system/network/cache2/CacheFileContextEvictor.cpp b/system/network/cache2/CacheFileContextEvictor.cpp
index 65feb4462..fd4e97550 100644
--- a/system/network/cache2/CacheFileContextEvictor.cpp
+++ b/system/network/cache2/CacheFileContextEvictor.cpp
@@ -269,7 +269,11 @@ CacheFileContextEvictor::PersistEvictionInfoToDisk(
   }
 
   nsAutoCString path;
+#ifdef XP_WIN
+  file->GetPersistentDescriptor(path);
+#else
   file->GetNativePath(path);
+#endif
 
   PRFileDesc *fd;
   rv = file->OpenNSPRFileDesc(PR_RDWR | PR_CREATE_FILE | PR_TRUNCATE, 0600,
@@ -306,7 +310,11 @@ CacheFileContextEvictor::RemoveEvictInfoFromDisk(
   }
 
   nsAutoCString path;
+#ifdef XP_WIN
+  file->GetPersistentDescriptor(path);
+#else
   file->GetNativePath(path);
+#endif
 
   rv = file->Remove(false);
   if (NS_WARN_IF(NS_FAILED(rv))) {
diff --git a/system/network/cache2/CacheFileIOManager.cpp b/system/network/cache2/CacheFileIOManager.cpp
index 845ad7314..627d06ffa 100644
--- a/system/network/cache2/CacheFileIOManager.cpp
+++ b/system/network/cache2/CacheFileIOManager.cpp
@@ -3096,7 +3096,11 @@ nsresult
 CacheFileIOManager::TrashDirectory(nsIFile *aFile)
 {
   nsAutoCString path;
+#ifdef XP_WIN
+  aFile->GetPersistentDescriptor(path);
+#else
   aFile->GetNativePath(path);
+#endif
   LOG(("CacheFileIOManager::TrashDirectory() [file=%s]", path.get()));
 
   nsresult rv;
@@ -3340,7 +3344,7 @@ CacheFileIOManager::RemoveTrashInternal()
                    "recursively, but this can block IO thread for a while!");
         if (LOG_ENABLED()) {
           nsAutoCString path;
-          file->GetNativePath(path);
+          file->GetPersistentDescriptor(path);
           LOG(("CacheFileIOManager::RemoveTrashInternal() - Found a directory in a trash "
               "directory! It will be removed recursively, but this can block IO "
               "thread for a while! [file=%s]", path.get()));
@@ -3873,7 +3877,7 @@ CacheFileIOManager::SyncRemoveDir(nsIFile *aFile, const char *aDir)
 
   if (LOG_ENABLED()) {
     nsAutoCString path;
-    file->GetNativePath(path);
+    file->GetPersistentDescriptor(path);
     LOG(("CacheFileIOManager::SyncRemoveDir() - Removing directory %s",
          path.get()));
   }
diff --git a/system/network/exthandler/nsMIMEInfoImpl.cpp b/system/network/exthandler/nsMIMEInfoImpl.cpp
index 59886e465..ca2372274 100644
--- a/system/network/exthandler/nsMIMEInfoImpl.cpp
+++ b/system/network/exthandler/nsMIMEInfoImpl.cpp
@@ -305,7 +305,11 @@ nsMIMEInfoBase::LaunchWithFile(nsIFile* aFile)
     NS_ENSURE_SUCCESS(rv, rv);
 
     nsAutoCString path;
+#ifdef XP_WIN
+    aFile->GetPersistentDescriptor(path);
+#else
     aFile->GetNativePath(path);
+#endif
     return LaunchWithIProcess(executable, path);
   }
 
@@ -423,7 +427,11 @@ nsMIMEInfoImpl::LaunchDefaultWithFile(nsIFile* aFile)
     return NS_ERROR_FILE_NOT_FOUND;
 
   nsAutoCString nativePath;
+#ifdef XP_WIN
+  aFile->GetPersistentDescriptor(nativePath);
+#else
   aFile->GetNativePath(nativePath);
+#endif
   
   return LaunchWithIProcess(mDefaultApplication, nativePath);
 }
diff --git a/system/network/test/TestFileInput2.cpp b/system/network/test/TestFileInput2.cpp
index f51988010..c75d7677c 100644
--- a/system/network/test/TestFileInput2.cpp
+++ b/system/network/test/TestFileInput2.cpp
@@ -323,8 +323,8 @@ Test(CreateFun create, uint32_t count,
 
     nsAutoCString inDir;
     nsAutoCString outDir;
-    (void)inDirSpec->GetNativePath(inDir);
-    (void)outDirSpec->GetNativePath(outDir);
+    (void)inDirSpec->GetPersistentDescriptor(inDir);
+    (void)outDirSpec->GetPersistentDescriptor(outDir);
     printf("###########\nTest: from %s to %s, bufSize = %d\n",
            inDir.get(), outDir.get(), bufSize);
     gTimeSampler.Reset();
diff --git a/system/runtime/nsUpdateDriver.cpp b/system/runtime/nsUpdateDriver.cpp
index 812818788..dadae7ba1 100644
--- a/system/runtime/nsUpdateDriver.cpp
+++ b/system/runtime/nsUpdateDriver.cpp
@@ -958,7 +958,13 @@ nsUpdateProcessor::ProcessUpdate(nsIUpdate* aUpdate)
     rv = ds->Get(XRE_EXECUTABLE_FILE, NS_GET_IID(nsIFile),
                  getter_AddRefs(binary));
     NS_ASSERTION(NS_SUCCEEDED(rv), "Can't get the binary path");
+#ifdef XP_WIN
+    nsAutoString binPathW;
+    binary->GetPath(binPathW);
+    NS_ConvertUTF16toUTF8 binPath(binPathW);
+#else
     binary->GetNativePath(binPath);
+#endif
   }
 
   // Copy the parameters to the StagedUpdateInfo structure shared with the
diff --git a/system/security/manager/ssl/CertBlocklist.cpp b/system/security/manager/ssl/CertBlocklist.cpp
index 8701032ed..43b99b359 100644
--- a/system/security/manager/ssl/CertBlocklist.cpp
+++ b/system/security/manager/ssl/CertBlocklist.cpp
@@ -193,7 +193,11 @@ CertBlocklist::Init()
     return rv;
   }
   nsAutoCString path;
+#ifdef XP_WIN
+  rv = mBackingFile->GetPersistentDescriptor(path);
+#else
   rv = mBackingFile->GetNativePath(path);
+#endif
   if (NS_FAILED(rv)) {
     return rv;
   }