summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorwolfbeast <mcwerewolf@wolfbeast.com>2020-01-29 09:08:00 +0100
committerwolfbeast <mcwerewolf@wolfbeast.com>2020-01-29 09:08:00 +0100
commitc63b7988a68bee5d3fe1891fb9132a321d3a9231 (patch)
tree295679e3f3fac4be3f265124bf0e4b707d5fd30a
parenta946f151b6886cb17951a2eabb1d4fe9dd85178b (diff)
downloadaura-central-c63b7988a68bee5d3fe1891fb9132a321d3a9231.tar.gz
[WebRequest] Remove AddonManagerPermissions leftovers
This was added as part of the WebExtension sec issue CVE-2017-5389. Since we no longer have this interface, it needed to be removed to prevent errors in the WebRequest channel callback.
-rw-r--r--dom/bindings/Bindings.conf5
-rw-r--r--toolkit/modules/addons/.eslintrc.js1
-rw-r--r--toolkit/modules/addons/WebRequest.jsm6
3 files changed, 1 insertions, 11 deletions
diff --git a/dom/bindings/Bindings.conf b/dom/bindings/Bindings.conf
index 9428529f4..feee2423a 100644
--- a/dom/bindings/Bindings.conf
+++ b/dom/bindings/Bindings.conf
@@ -53,11 +53,6 @@ DOMInterfaces = {
'concrete': False
},
-'AddonManagerPermissions': {
- 'wrapperCache': False,
- 'concrete': False
-},
-
'AnimationEffectReadOnly': {
'concrete': False
},
diff --git a/toolkit/modules/addons/.eslintrc.js b/toolkit/modules/addons/.eslintrc.js
index 019759c87..32c92be0a 100644
--- a/toolkit/modules/addons/.eslintrc.js
+++ b/toolkit/modules/addons/.eslintrc.js
@@ -8,7 +8,6 @@ module.exports = { // eslint-disable-line no-undef
"addMessageListener": false,
"removeEventListener": false,
"sendAsyncMessage": false,
- "AddonManagerPermissions": false,
"initialProcessData": true,
},
diff --git a/toolkit/modules/addons/WebRequest.jsm b/toolkit/modules/addons/WebRequest.jsm
index c720dae5d..76114d7ba 100644
--- a/toolkit/modules/addons/WebRequest.jsm
+++ b/toolkit/modules/addons/WebRequest.jsm
@@ -720,11 +720,7 @@ HttpObserverManager = {
try {
let result = callback(data);
- if (result && typeof result === "object" && opts.blocking
- && !AddonManagerPermissions.isHostPermitted(uri.host)
- && (!loadInfo || !loadInfo.loadingPrincipal
- || !loadInfo.loadingPrincipal.URI
- || !AddonManagerPermissions.isHostPermitted(loadInfo.loadingPrincipal.URI.host))) {
+ if (result && typeof result === "object" && opts.blocking) {
handlerResults.push({opts, result});
}
} catch (e) {