From a05a65278058562ce7bcab7b6a58e256436aa853 Mon Sep 17 00:00:00 2001 From: Moonchild Date: Fri, 4 Mar 2022 14:21:28 +0000 Subject: Issue #2 - Stop using unified building in Spidermonkey --- js/src/gdb/moz.build | 2 +- js/src/jit/moz.build | 34 +++++++++++++++++----------------- js/src/moz.build | 29 +++++++++-------------------- js/src/wasm/moz.build | 2 +- 4 files changed, 28 insertions(+), 39 deletions(-) diff --git a/js/src/gdb/moz.build b/js/src/gdb/moz.build index 01f6cb0b6..c0f3ba754 100644 --- a/js/src/gdb/moz.build +++ b/js/src/gdb/moz.build @@ -7,7 +7,7 @@ GeckoProgram('gdb-tests', linkage=None) include('../js-cxxflags.mozbuild') -UNIFIED_SOURCES += [ +SOURCES += [ 'gdb-tests.cpp', 'tests/test-asmjs.cpp', 'tests/test-ExecutableAllocator.cpp', diff --git a/js/src/jit/moz.build b/js/src/jit/moz.build index e8b463112..0c6c4f3b8 100644 --- a/js/src/jit/moz.build +++ b/js/src/jit/moz.build @@ -11,7 +11,7 @@ FINAL_LIBRARY = "js" # Includes should be relative to parent path LOCAL_INCLUDES += ["!..", ".."] -UNIFIED_SOURCES += [ +SOURCES += [ 'AliasAnalysis.cpp', 'AliasAnalysisShared.cpp', 'AlignmentMaskAnalysis.cpp', @@ -83,14 +83,14 @@ UNIFIED_SOURCES += [ ] if CONFIG['MOZ_DEBUG']: - UNIFIED_SOURCES += ['Disassembler.cpp'] + SOURCES += ['Disassembler.cpp'] if not CONFIG['ENABLE_ION']: - UNIFIED_SOURCES += [ + SOURCES += [ 'none/Trampoline-none.cpp' ] elif CONFIG['JS_CODEGEN_X86'] or CONFIG['JS_CODEGEN_X64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'x86-shared/Architecture-x86-shared.cpp', 'x86-shared/Assembler-x86-shared.cpp', 'x86-shared/AssemblerBuffer-x86-shared.cpp', @@ -101,11 +101,11 @@ elif CONFIG['JS_CODEGEN_X86'] or CONFIG['JS_CODEGEN_X64']: 'x86-shared/MacroAssembler-x86-shared.cpp', 'x86-shared/MoveEmitter-x86-shared.cpp', ] - UNIFIED_SOURCES += [ + SOURCES += [ 'x86-shared/Disassembler-x86-shared.cpp', # using namespace js::jit::X86Encoding; ] if CONFIG['JS_CODEGEN_X64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'x64/Assembler-x64.cpp', 'x64/Bailouts-x64.cpp', 'x64/BaselineCompiler-x64.cpp', @@ -117,7 +117,7 @@ elif CONFIG['JS_CODEGEN_X86'] or CONFIG['JS_CODEGEN_X64']: 'x64/Trampoline-x64.cpp', ] else: - UNIFIED_SOURCES += [ + SOURCES += [ 'x86/Assembler-x86.cpp', 'x86/Bailouts-x86.cpp', 'x86/BaselineCompiler-x86.cpp', @@ -129,7 +129,7 @@ elif CONFIG['JS_CODEGEN_X86'] or CONFIG['JS_CODEGEN_X64']: 'x86/Trampoline-x86.cpp', ] elif CONFIG['JS_CODEGEN_ARM']: - UNIFIED_SOURCES += [ + SOURCES += [ 'arm/Architecture-arm.cpp', 'arm/Assembler-arm.cpp', 'arm/Bailouts-arm.cpp', @@ -145,16 +145,16 @@ elif CONFIG['JS_CODEGEN_ARM']: 'arm/Trampoline-arm.cpp', ] if CONFIG['JS_SIMULATOR_ARM']: - UNIFIED_SOURCES += [ + SOURCES += [ 'arm/Simulator-arm.cpp' ] elif CONFIG['OS_ARCH'] == 'Darwin': - UNIFIED_SOURCES += [ + SOURCES += [ 'arm/llvm-compiler-rt/arm/aeabi_idivmod.S', 'arm/llvm-compiler-rt/arm/aeabi_uidivmod.S', ] elif CONFIG['JS_CODEGEN_ARM64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'arm64/Architecture-arm64.cpp', 'arm64/Assembler-arm64.cpp', 'arm64/Bailouts-arm64.cpp', @@ -177,14 +177,14 @@ elif CONFIG['JS_CODEGEN_ARM64']: 'arm64/vixl/Utils-vixl.cpp' ] if CONFIG['JS_SIMULATOR_ARM64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'arm64/vixl/Debugger-vixl.cpp', 'arm64/vixl/Logic-vixl.cpp', 'arm64/vixl/MozSimulator-vixl.cpp', 'arm64/vixl/Simulator-vixl.cpp' ] elif CONFIG['JS_CODEGEN_MIPS32'] or CONFIG['JS_CODEGEN_MIPS64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'mips-shared/Architecture-mips-shared.cpp', 'mips-shared/Assembler-mips-shared.cpp', 'mips-shared/Bailouts-mips-shared.cpp', @@ -196,7 +196,7 @@ elif CONFIG['JS_CODEGEN_MIPS32'] or CONFIG['JS_CODEGEN_MIPS64']: 'mips-shared/MoveEmitter-mips-shared.cpp', ] if CONFIG['JS_CODEGEN_MIPS32']: - UNIFIED_SOURCES += [ + SOURCES += [ 'mips32/Architecture-mips32.cpp', 'mips32/Assembler-mips32.cpp', 'mips32/Bailouts-mips32.cpp', @@ -210,11 +210,11 @@ elif CONFIG['JS_CODEGEN_MIPS32'] or CONFIG['JS_CODEGEN_MIPS64']: 'mips32/Trampoline-mips32.cpp', ] if CONFIG['JS_SIMULATOR_MIPS32']: - UNIFIED_SOURCES += [ + SOURCES += [ 'mips32/Simulator-mips32.cpp' ] elif CONFIG['JS_CODEGEN_MIPS64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'mips64/Architecture-mips64.cpp', 'mips64/Assembler-mips64.cpp', 'mips64/Bailouts-mips64.cpp', @@ -228,6 +228,6 @@ elif CONFIG['JS_CODEGEN_MIPS32'] or CONFIG['JS_CODEGEN_MIPS64']: 'mips64/Trampoline-mips64.cpp', ] if CONFIG['JS_SIMULATOR_MIPS64']: - UNIFIED_SOURCES += [ + SOURCES += [ 'mips64/Simulator-mips64.cpp' ] diff --git a/js/src/moz.build b/js/src/moz.build index 6664007ad..865e964e1 100644 --- a/js/src/moz.build +++ b/js/src/moz.build @@ -131,18 +131,22 @@ if not CONFIG['JS_DISABLE_SHELL']: if CONFIG['MOZ_VTUNE']: DIRS += ['vtune'] -UNIFIED_SOURCES += [ +SOURCES += [ 'jsalloc.cpp', 'jsapi.cpp', + 'jsarray.cpp', + 'jsatom.cpp', 'jsbool.cpp', 'jscntxt.cpp', 'jscompartment.cpp', 'jsdate.cpp', + 'jsdtoa.cpp', 'jsexn.cpp', 'jsfriendapi.cpp', 'jsfun.cpp', 'jsgc.cpp', 'jsiter.cpp', + 'jsmath.cpp', 'jsnativestack.cpp', 'jsnum.cpp', 'jsobj.cpp', @@ -152,16 +156,8 @@ UNIFIED_SOURCES += [ 'jspropertytree.cpp', 'jsscript.cpp', 'jsstr.cpp', - 'jsweakmap.cpp', -] - -# Can't be built unified -SOURCES += [ - 'jsarray.cpp', - 'jsatom.cpp', - 'jsdtoa.cpp', - 'jsmath.cpp', 'jsutil.cpp', + 'jsweakmap.cpp', ] # Suppress warnings in third-party code. @@ -169,7 +165,7 @@ SOURCES += [ if CONFIG['CLANG_CXX'] or CONFIG['GNU_CXX']: SOURCES['jsdtoa.cpp'].flags += ['-Wno-implicit-fallthrough'] -UNIFIED_SOURCES += [ +SOURCES += [ 'vm/ArgumentsObject.cpp', 'vm/ArrayBufferObject.cpp', 'vm/AsyncFunction.cpp', @@ -189,6 +185,7 @@ UNIFIED_SOURCES += [ 'vm/GlobalObject.cpp', 'vm/HelperThreads.cpp', 'vm/Id.cpp', + 'vm/Initialization.cpp', 'vm/Interpreter.cpp', 'vm/JSONParser.cpp', 'vm/MemoryMetrics.cpp', @@ -230,18 +227,12 @@ UNIFIED_SOURCES += [ 'vm/Xdr.cpp', ] -# Can't be built unified -SOURCES += [ - 'vm/Initialization.cpp', -] - if CONFIG['JS_POSIX_NSPR']: - UNIFIED_SOURCES += [ + SOURCES += [ 'vm/PosixNSPR.cpp', ] if CONFIG['ENABLE_TRACE_LOGGING']: - # Can't be built unified SOURCES += [ 'vm/TraceLogging.cpp', 'vm/TraceLoggingGraph.cpp', @@ -305,5 +296,3 @@ OS_LIBS += CONFIG['REALTIME_LIBS'] NO_EXPAND_LIBS = True DIST_INSTALL = True - - diff --git a/js/src/wasm/moz.build b/js/src/wasm/moz.build index 5fe046add..6a47df322 100644 --- a/js/src/wasm/moz.build +++ b/js/src/wasm/moz.build @@ -11,7 +11,7 @@ FINAL_LIBRARY = "js" # Includes should be relative to parent path LOCAL_INCLUDES += ["!..", ".."] -UNIFIED_SOURCES += [ +SOURCES += [ 'AsmJS.cpp', 'WasmBaselineCompile.cpp', 'WasmBinaryFormat.cpp', -- cgit v1.2.3